Unexpected getResultStream() behavior - onClose not called

Hi,

I am using getResultStream() and just found what I think is an unexpected behavior.

Using Hibernate 5.4.18.Final;

This code should print “closed”, but it doesn’t.

var query = em.createNativeQuery("select 1");
Stream<Object> stream = query.getResultStream();
stream = stream.onClose(() -> System.out.println("closed"));
stream.close();
// nothing printed

We can check this using a regular java stream:

var stream = Arrays.asList(new int[] {}).stream();
stream = stream.onClose(() -> System.out.println("closed"));
stream.close();
// prints closed

I think the problem is related to the class StreamDecorator.
It seems this class tries to deal with closeHandlers, but I don’t think this class is needed at all.
Acording to Stream specs, we can add many closeHandlers to a stream, and they will be all executed in the order they were added.
It seems the developer misunderstood that, thinking there would be just one closeHandler for a stream, and he tried to deal with the possibility of someone add another closeHandler.
As you can see, we can register many closeHandlers, so it seems the standard Java implementation can handle this.

var stream = Arrays.asList(new int[] {}).stream();
stream = stream.onClose(() -> System.out.println("closed 1"));
stream = stream.onClose(() -> System.out.println("closed 2"));
stream.close();
// prints closed 1
// prints closed 2

Looking at AbstractProducedQuery.stream() method, which calls StreamDecorator:

		final Stream<R> stream = new StreamDecorator(
				StreamSupport.stream( spliterator, false ),
				scrollableResults::close
		);
		return stream;
	}

It seems this would be enough (didn’t check).

return StreamSupport.stream( spliterator, false ).onClose(scrollableResults::close);

Best regards,

Fabiano

PS:

Just tested the code and confirmed you don’t need StreamDecorator.
This class can be removed safely and we will get the expected behavior (ScrollableResultsImpl.close() will be called, and also any post appended closeHandlers).

I am new to this forum. Is this the right place to report bugs and/or to proppose code changes?