Legacy-hilo optimizer does not generate the correct value

hibernateUser · February 26, 2024, 7:00pm

I migrated from Hibernate 5 to 6, in the old implementation I used SequenceGenerator @SequenceGenerator(name = "SEQ_NAME", sequenceName = "SEQ_NAME", allocationSize = 50), this called SequenceHiLoGenerator and LegacyHiLoAlgorithmOptimizer.

The behavior was: if the last value of sequence in database is 100, the value is multiplied by allocationSize (100x50=5000), the value of sequence stared in 5000, 5001…5049.

The hibernate 6 version multiple by allocationSize/incrementSize +1.

Below code segment is the implementation of sequence in hibernate 6

@GenericGenerator(
        name = "X_SEQ",
        type = org.hibernate.id.enhanced.SequenceStyleGenerator.class,
        parameters = {
            @Parameter(name = "sequence_name", value = "X_SEQ"),
            @Parameter(name = "initial_value", value = "1"),
            @Parameter(name = "increment_size", value = "50"),
            @Parameter(name = "optimizer", value = "legacy-hilo")
        })

Same example, last value of sequence in database is 100, the value is multiplied by increment_size+1 (100x51=5100), the value of sequence stared in 5100, 5101…5149.

In hibernate 5 the maxLo value is 49 (allocationSize-1), in hibernate 6 the maxLo is the same incrementSize (50)

github.com

hibernate/hibernate-orm/blob/main/hibernate-core/src/main/java/org/hibernate/id/enhanced/LegacyHiLoAlgorithmOptimizer.java#L66


      
          
          	@Override
          	public Serializable generate(AccessCallback callback) {
          		lock.lock();
          		try {
          			final GenerationState generationState = locateGenerationState( callback.getTenantIdentifier() );
          
          			if ( generationState.lo > generationState.maxLo ) {
          				generationState.lastSourceValue = callback.getNextValue();
          				generationState.lo = generationState.lastSourceValue.eq( 0 ) ? 1 : 0;
          				generationState.hi = generationState.lastSourceValue.copy().multiplyBy( generationState.maxLo + 1 );
          			}
          			generationState.value = generationState.hi.copy().add( generationState.lo++ );
          			return generationState.value.makeValue();
          		}
          		finally {
          			lock.unlock();
          		}
          
          	}

Is this a bug?
Did I miss something in the configuration?

Thanks in advance.

beikov · February 27, 2024, 10:56am

I gave the code a quick look but couldn’t find a difference between 5 and 6 that would explain this. Please try to create a reproducer with our test case template and if you are able to reproduce the issue, create a bug ticket in our issue tracker and attach that reproducer. Ideally, you’d also provide a reproducer based on ORM 5, for which you should be able to just copy and paste the code.

Topic		Replies	Views
@SequenceGenerator: allocationSize versus INCREMENT BY Hibernate ORM	7	16322	February 19, 2021
Migrating from Hibernate 3 to 5 and hilo deprecation Hibernate ORM	0	356	June 11, 2020
Hibernate 6 Migration - Id Generation Hibernate ORM	3	955	April 26, 2023
About the sequence When Insert Batch Hibernate ORM	8	8658	January 26, 2019
org.hibernate.MappingException: The increment size of the [xyz] sequence is set to [50] in the entity mapping while the associated database sequence increment size is [1] Hibernate ORM	1	3207	October 31, 2022

Legacy-hilo optimizer does not generate the correct value

Related Topics