Deprecation of Hibernate Criteria and how we can still prevent it

[graemerocher]

Ok, that is good to know. We will try migrate what we can, but the scale of GORM’s use of Criteria makes it difficult to migrate everything. For example here is the criteria builder DSL:

grails/gorm-hibernate5/blob/master/grails-datastore-gorm-hibernate5/src/main/groovy/org/grails/orm/hibernate/query/AbstractHibernateCriteriaBuilder.java

Completely based on Hibernate Criteria. Also extensively used for dynamic finder creation:

grails/gorm-hibernate5/blob/master/grails-datastore-gorm-hibernate5/src/main/groovy/org/grails/orm/hibernate/query/AbstractHibernateQuery.java

I think we maybe migrate 80% to JPA 2.0, but it is the 20% I am concerned about and we need to make a decision on what features we deprecate for users and how much of the Criteria API usage we remove.